HD Split: Avoid redundant upgrades

This avoids repeaded upgrades when support for more multiple keyman references is added in the next commit: bitcoin#16341 (comment)
ryanofsky · Oct 25, 2019 · 4eb8c89 · 4eb8c89
1 parent 85ecb42
commit 4eb8c89
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/wallet/scriptpubkeyman.cpp b/src/wallet/scriptpubkeyman.cpp
@@ -410,7 +410,7 @@ bool LegacyScriptPubKeyMan::Upgrade(int prev_version, std::string& error)
         hd_upgrade = true;
     }
     // Upgrade to HD chain split if necessary
-    if (m_storage.CanSupportFeature(FEATURE_HD_SPLIT)) {
+    if (m_storage.CanSupportFeature(FEATURE_HD_SPLIT) && hdChain.nVersion < 2 /* VERSION_HD_CHAIN_SPLIT */) {
         WalletLogPrintf("Upgrading wallet to use HD chain split\n");
         m_storage.SetMinVersion(FEATURE_PRE_SPLIT_KEYPOOL);
         split_upgrade = FEATURE_HD_SPLIT > prev_version;