Key pool: Move TopUp call

This avoids extra keyman map lookup: bitcoin#16341 (comment), but may be "annoying" and lead to unnecessary topups in some situations: bitcoin#16341 (comment)
ryanofsky · Oct 7, 2019 · 721b341 · 721b341
1 parent 7126df8
commit 721b341
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -3085,8 +3085,6 @@ bool CWallet::GetNewChangeDestination(const OutputType type, CTxDestination& des
     LOCK(cs_wallet);
     error.clear();
 
-    m_spk_man->TopUp();
-
     ReserveDestination reservedest(this);
     if (!reservedest.GetReservedDestination(type, dest, true)) {
         error = "Error: Keypool ran out, please call keypoolrefill first";
@@ -3261,6 +3259,7 @@ bool ReserveDestination::GetReservedDestination(const OutputType type, CTxDestin
         return false;
     }
 
+    m_spk_man->TopUp();
 
     if (nIndex == -1)
     {