Skip to content

Commit

Permalink
Remove outdated blockstorage namespace todo
Browse files Browse the repository at this point in the history
TODO doesn't really make sense. It would turn some public global
variables into private global variables, but really they shouldn't be
global variables at all. They should be block manager member variables
or chainstate manager member variables.

TODO was added by MarcoFalke <falke.marco@gmail.com> in
fa247a3 in bitcoin#21727 and noticed by Samuel
Dobson <dobsonsa68@gmail.com>
bitcoin#23497 (comment)
  • Loading branch information
ryanofsky committed Dec 30, 2021
1 parent 4decc9a commit 76e3dda
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/node/blockstorage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ bool fHavePruned = false;
bool fPruneMode = false;
uint64_t nPruneTarget = 0;

// TODO make namespace {
RecursiveMutex cs_LastBlockFile;
std::vector<CBlockFileInfo> vinfoBlockFile;
int nLastBlockFile = 0;
Expand All @@ -42,7 +41,6 @@ std::set<CBlockIndex*> setDirtyBlockIndex;

/** Dirty block file entries. */
std::set<int> setDirtyFileInfo;
// } // namespace

static FILE* OpenUndoFile(const FlatFilePos& pos, bool fReadOnly = false);
static FlatFileSeq BlockFileSeq();
Expand Down

0 comments on commit 76e3dda

Please sign in to comment.