RtlSecureZeroMemory bug fix

ryanries · Jun 21, 2019 · 80734d8 · 80734d8
1 parent 8e77180
commit 80734d8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/PassFiltEx.c b/PassFiltEx.c
@@ -635,7 +635,9 @@ __declspec(dllexport) BOOL CALLBACK PasswordFilter(_In_ PUNICODE_STRING AccountN
 
 	EventWriteStringW2(L"[%s:%s@%d] Finished in %llu microseconds. Will accept new password: %d", __FILENAMEW__, __FUNCTIONW__, __LINE__, ElapsedMicroseconds.QuadPart, PasswordIsOK);
 
-	RtlSecureZeroMemory(Password, Password->Length);
+	RtlSecureZeroMemory(&Password, Password->Length);
+
+	RtlSecureZeroMemory(PasswordCopy, sizeof(PasswordCopy));
 
 	LeaveCriticalSection(&gBlacklistCritSec);
 

diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@ PassFiltEx.c
 
 # PassFiltEx by Joseph Ryan Ries
 
-Author: Joseph Ryan Ries 2018 <ryanries09@gmail.com> <ryan.ries@microsoft.com>
+Author: Joseph Ryan Ries 2019 <ryanries09@gmail.com> <ryan.ries@microsoft.com>
 
 A password filter for Active Directory that uses a blacklist of bad passwords/character sequences.