Replay Alex Chaffee's commits on top of current master #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: spec/operations/create_hit_spec.rb
…n the CreateHIT operation
…its real name (RequesterAnnotation)
…ency with its real name (MaxAssignments) and to remove confusion between it and the other property named 'assignments'
…ke either a QF or just its content; fix another method_missing problem Conflicts: lib/rturk/parsers/responses/get_hit_response.rb
…ments - see https://forums.aws.amazon.com/thread.jspa?threadID=70812 Conflicts: lib/rturk/builders/qualification_builder.rb
Conflicts: lib/rturk/builders/qualification_builder.rb
Conflicts: lib/rturk/builders/qualification_builder.rb
Conflicts: Gemfile
|
This looks good, however it's exposed a problem with Nokogiri not working on 1.8.7. So from this release forward I'm going to just support 1.9.2 and up. I'll release 2.10.3 as the last ruby 1.8.7 build, and I'll bump the release to 2.11.0 to include this PR and only be Ruby >1.9.2 compatible. I'll have this in first thing tomorrow morning when I get more time. Thanks for taking the time to get this in. |
|
Thanks @mdp! |
|
Yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replays Alex's work from 2 years ago on adding QuestionForm support to rturk, as well as some of his other small refactors. I left out the rspec2 upgrade because that seemed to be receiving pushback. Specs are all passing.