Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add home-manager module #109

Closed
wants to merge 2 commits into from
Closed

WIP: add home-manager module #109

wants to merge 2 commits into from

Conversation

Kranzes
Copy link

@Kranzes Kranzes commented Mar 29, 2022

No description provided.

modules/home-age.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@montchr montchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple thoughts on the owner option…

modules/home-age.nix Outdated Show resolved Hide resolved
modules/home-age.nix Outdated Show resolved Hide resolved
@montchr
Copy link
Contributor

montchr commented Apr 5, 2022

Also, considering these are user-specific secrets, is there still a need to manage owner/group or store at /run/user/...? Since the owner option is read-only, does the owner need to be an option at all?

in
{
options.age = {
ageBin = mkOption {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about package instead of ageBin?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will change tomorrow

Co-authored-by: Chris Montgomery <chris@cdom.io>
@ambroisie
Copy link
Contributor

Hello, I wanted to know what is keeping this MR as a draft?

@Kranzes
Copy link
Author

Kranzes commented Feb 21, 2023

Hello, I wanted to know what is keeping this MR as a draft?

Me not caring enough, the changes in the PR don't function as you'd expect yet.

@ambroisie
Copy link
Contributor

ambroisie commented Feb 21, 2023

@Kranzes have you seen the previous PR to add a home-manager module?

I see that you do not have the DRY_RUN_CMD necessary for home-manager switch -n when I compare both. There is also some interesting discussion about the shortcomings of the previous implementation.

EDIT: I know @RaitoBezarius was dogfooding his module, so it could be a good basis for comparison.

n8henrie pushed a commit to n8henrie/agenix that referenced this pull request May 5, 2023
This is to update and fix the issues I saw in [1] and [2].

Using a service definition instead of an activation script should
resolve the issue about the secrets disappearing after rebooting.

Removed the `user` and `group` option as they do not make sense to me
for a home-manager module, which should target a single user. They can
always be added back if somebody comes screaming.

This is somewhat modeled after sops-nix's own module [3].

[1]: ryantm#58
[2]: ryantm#109
[3]: https://github.com/Mic92/sops-nix/blob/master/modules/home-manager/sops.nix
@ryantm ryantm closed this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants