-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add home-manager module #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple thoughts on the owner
option…
Also, considering these are user-specific secrets, is there still a need to manage owner/group or store at |
in | ||
{ | ||
options.age = { | ||
ageBin = mkOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about package
instead of ageBin
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will change tomorrow
Co-authored-by: Chris Montgomery <chris@cdom.io>
Hello, I wanted to know what is keeping this MR as a draft? |
Me not caring enough, the changes in the PR don't function as you'd expect yet. |
@Kranzes have you seen the previous PR to add a home-manager module? I see that you do not have the EDIT: I know @RaitoBezarius was dogfooding his module, so it could be a good basis for comparison. |
This is to update and fix the issues I saw in [1] and [2]. Using a service definition instead of an activation script should resolve the issue about the secrets disappearing after rebooting. Removed the `user` and `group` option as they do not make sense to me for a home-manager module, which should target a single user. They can always be added back if somebody comes screaming. This is somewhat modeled after sops-nix's own module [3]. [1]: ryantm#58 [2]: ryantm#109 [3]: https://github.com/Mic92/sops-nix/blob/master/modules/home-manager/sops.nix
No description provided.