-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add git diff filter support #14
Conversation
@blaggacao What are you trying to achieve with a git filter? |
Oh, sorry, implicit context 😝 Simply to replace |
Unless we can come up with some better plan for how to import the files into the NixOS configuration, they need to be encrypted at rest. |
PS: seems as this is the way git crypt works, itself: https://github.com/nrdxp/nixflk/blob/37d40e0cfe4e770a1ef388e93de3bd048d5aaee7/.gitattributes#L1 |
My assumption was somehow that those git attributes would only affect the git editing workflow. Didn't realize that the checkout is our "at rest" as well. What would happen if we only implement the diff filter? without the smudge and clean? Could be then we would gain elegant diffing, but keeping them encrypted at rest... |
Yeah, a diff filter would be good. Sops supports that. https://github.com/mozilla/sops#showing-diffs-in-cleartext-in-git |
I'll comply this PR to this. Thanks for the advice and the argument. |
function git_diff_textconv { | ||
FILE=$1 | ||
_decrypt_args | ||
DECRYPT+=("$FILE") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still have to check this at occasion
I'm closing this since it has had a merge conflict for a while and no one else has voiced their interest. If this gets picked up again, we should have tests for it. |
attempt towards #11 — please feel free to refine since I don't feel competent for a proper implementation.