Parsing boolean expressions with the QueryBuilder #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While converting my old queries to Dapper linq I've run into an issue parsing expressions like:
Expression<Func<Person, bool>> expression = e => e.Id == 14 && e.Active;
The quick fix to make Dapper handle it is to rewrite it as:
Expression<Func<Person, bool>> expression = e => e.Id == 14 && e.Active == true;
But ReSharper complains about such things and following its refactoring suggestions would break the query.
This is why I've enhaced the QueryBuilder to handle this case.