Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to redux, query components, & the wordpress-rest-api module #4

Merged
merged 58 commits into from
Jun 18, 2016

Conversation

ryelle
Copy link
Owner

@ryelle ryelle commented Jun 18, 2016

stream of consciousness PR, mostly for personal notes

Adds redux + query components in a submodule; perhaps eventually to be released as an npm module – or two? trying to separate them out was harder than it seemed, but a lot has changed while working to this point. trying again in the future is possible. Might also disregard the "ducks" approach if so, and bundle instead with each query-component?

Other updates:

  • Injects the nav menu as an object into the page, rather than calling the API to load it.
  • Removes gulp
  • es2015 refactor
  • Switches to react-router (from page), which introduces new routing.
  • Permalinks need to change slightly -- /page/X is now /p/X, date archives are prefixed with date, pages prefixed with page.

Somewhere along the lines I've introduced a javascript error Uncaught TypeError: Cannot read property 'replaceChild' of null — but everything appears to work anyway? Thinking it's related to the query components. (will handle in future commits)

@ryelle ryelle merged commit d6887ea into master Jun 18, 2016
@ryelle ryelle deleted the switch/external-api-client branch October 9, 2016 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant