Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Title, body, and icon should all be optional. Setting no icon currently results in broken notifications such as:
![image](https://private-user-images.githubusercontent.com/11866552/326507108-2cfa3e12-4fce-4a43-a67e-585d334e3043.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3OTgzMzgsIm5iZiI6MTcyMDc5ODAzOCwicGF0aCI6Ii8xMTg2NjU1Mi8zMjY1MDcxMDgtMmNmYTNlMTItNGZjZS00YTQzLWE2N2UtNTg1ZDMzNGUzMDQzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDE1MjcxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY1YzFlMjVkMDUxYmI2OTUyMTJjYzZkNmE1YjczYWZjYTg0YmNjNWZhY2Y1MjM2YjNmZDNmYjQ3YWIzODQxZGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rYATp4MhmVNU7YkeXmfIlihupPgCrWjuloVsster94k)
This PR fixes that by making the icon optional.
![image](https://private-user-images.githubusercontent.com/11866552/326507526-660af72a-3851-4475-84a8-8c6972c7a9aa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3OTgzMzgsIm5iZiI6MTcyMDc5ODAzOCwicGF0aCI6Ii8xMTg2NjU1Mi8zMjY1MDc1MjYtNjYwYWY3MmEtMzg1MS00NDc1LTg0YTgtOGM2OTcyYzdhOWFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEyVDE1MjcxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEwM2QzNTQwOTM3Nzg2MjA2MGM1M2Y1ZTkxMGVkN2RkMDRkYThhOTllYjc0ZWJiYWQ5OTFlZjNhNjlkOGFkZWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XIglrlndf4QySCeT2znZZCJrxTLOz3CzEvZ1AwWcV-0)