Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Config options as optional in TypeScript typings #36

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Mark Config options as optional in TypeScript typings #36

merged 1 commit into from
Nov 21, 2019

Conversation

pe8ter
Copy link
Contributor

@pe8ter pe8ter commented Nov 20, 2019

With strict typings enabled, consumers are forced to specify all fields for the Config object, even though configureInstaller(conf) already handles missing fields.

Right now I have to do this

DynamoDbLocal.configureInstaller({
    installPath: '/path/to/my/tmp',
    downloadUrl: null
});

when I should be able to do this

DynamoDbLocal.configureInstaller({
    installPath: '/path/to/my/tmp'
});

@rynop rynop merged commit 3632f99 into rynop:master Nov 21, 2019
@rynop
Copy link
Owner

rynop commented Nov 21, 2019

v0.0.31 published. Thanks!

@pe8ter
Copy link
Contributor Author

pe8ter commented Nov 21, 2019

No prob. Thanks for the fast turnaround!

@pe8ter pe8ter deleted the optional-options branch November 21, 2019 02:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants