fix windows cmd line #108
Merged
fix windows cmd line #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireice-uk
force-pushed
the
topic-fix-win-cmd
branch
from
b30a269
to
557473d
Compare
fireice-uk
force-pushed
the
topic-fix-win-cmd
branch
from
557473d
to
cd1d9d2
Compare
psychocrypt
approved these changes
Sep 4, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
std::stringin this context produced a bug where small string optimisations kicked in. Since this is C-style API, I opted for C-style method of a single combined-string buffer instead.The buffer is not deleted at all. The only safe place where we can do it is just before the program close. And once my professor compared that kind of thing to cleaning up your bedroom just before a wrecking ball drives through your house.