Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-threaded wallet scan #206

Merged
merged 6 commits into from
Jul 31, 2019

Conversation

fireice-uk
Copy link
Member

@fireice-uk fireice-uk commented Jul 25, 2019

Upgrade multithreading in the wallet to something that has actually a fighting chance of maxing out the CPU.

  • Use of 64 bit lib is conservative, there is no way to produce anything but false negatives if there is an exploitable problem there.
  • We strip away the abstraction layers in 64 bit code (mostly to avoid giving a blueprint for a parallel hw wallet implementation to guys that should really have been able to figure it out on their own)
  • Bottleneck now is the block feed speed
  • Time improvement will vary depending on the point above. HDDs won't see a lot. High IOPS NVMe SSDs will improve most. Overall 2 to 5x is a good ballpark figure so far.

@psychocrypt psychocrypt self-requested a review July 26, 2019 18:57
@psychocrypt psychocrypt self-assigned this Jul 26, 2019
@psychocrypt psychocrypt added the enhancement New feature or request label Jul 26, 2019
@psychocrypt psychocrypt added this to the 0.5.0.0/0.4.X.X milestone Jul 26, 2019
src/wallet/wallet2.cpp Outdated Show resolved Hide resolved
src/wallet/wallet2.cpp Outdated Show resolved Hide resolved
src/wallet/wallet2.cpp Outdated Show resolved Hide resolved
@psychocrypt psychocrypt merged commit 0d0b622 into ryo-currency:dev Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants