Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement stricter tx semantics #46

Merged
merged 1 commit into from Jul 21, 2018

Conversation

fireice-uk
Copy link
Member

Implement stricter tx semantics rules:

  • Only one pubkey per tx
  • Only one extra pubkeys field per tx
  • Extra pubkeys size must match outputs size
  • Each input must have the same mixin size
  • Activate sorted inputs check

#endif
if(strict_tx_semantics)
{
const crypto::key_image *last_key_image = NULL;

This comment was marked as abuse.

if(strict_tx_semantics)
{
const crypto::key_image *last_key_image = NULL;
for (size_t n = 0; n < tx.vin.size(); ++n)

This comment was marked as abuse.

@psychocrypt psychocrypt self-assigned this Jul 20, 2018
@psychocrypt psychocrypt added the enhancement New feature or request label Jul 20, 2018
@fireice-uk
Copy link
Member Author

I implemented your suggestions.

@psychocrypt psychocrypt merged commit f210f5d into ryo-currency:dev Jul 21, 2018
@psychocrypt psychocrypt added this to the 0.3.0.0 milestone Jul 25, 2018
@fireice-uk fireice-uk deleted the topic-strict-tx-sem branch August 24, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants