remove address from DNS txt record #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireice-uk
requested changes
Aug 6, 2018
| @@ -376,10 +376,8 @@ bool get_account_address_from_str_or_url( | |||
| { | |||
| if(get_account_address_from_str(nettype, info, str_or_url)) | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
The function to read a address from an DNS txt record is not needed. To reduce the code-base all coresponding functions will be removed in this PR.
psychocrypt
force-pushed
the
topic-removeAdressFromDnsTxtRecord
branch
from
0456ff0
to
aed0e5e
Compare
|
I removed the function |
This method is not longer needed and replaced with `get_account_address_from_str`. Add instantiation for all three networks for `get_account_address_from_str`.
psychocrypt
force-pushed
the
topic-removeAdressFromDnsTxtRecord
branch
from
aed0e5e
to
7c1462e
Compare
fireice-uk
approved these changes
Aug 8, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function to read a address from an DNS txt record is not needed.
To reduce the code-base all corresponding functions will be removed in this PR.