fix wrong exit code for --help
#90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user ask the app for to show the help the most binaries currently returning the exit code `1`. Asking for a the help essage and get them showed without error must be return zero because the user requested action is fulfilled. - return exit code zero user request `-h/--help` - return exit code zero if `--version` is requested and a valid cli option
fireice-uk
approved these changes
Aug 13, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user ask the app to show the help the most binaries currently returning the exit code
1.Asking for a the help message and get them showed without errors must be return the exit code zero because the user requested action is fulfilled.
-h/--help--versionis requested and a valid cli option