Upgrade prng to c++ #92

fireice-uk · 2018-08-14T15:27:00Z

Use C++ and remove INITIALIZER

I removed a global random seed, as this is insecure. Instead we either use the randomness function directly or we use keccak hashes of a random seed stored on stack.

This might complicate test slightly. If you need to fix the prng for the test, I recommend wiring something based on C++11 mt just for tests, enabled by #define.

src/crypto/random.cpp

+
+void prng::generate_random(uint8_t* output, size_t size_bytes)
+{
+	if(hnd == nullptr)


src/crypto/random.cpp

+{
+	hnd = new prng_handle;
+#if defined(_WIN32)
+	if(!CryptAcquireContext(&hnd->prov, NULL, NULL, PROV_RSA_FULL, CRYPT_VERIFYCONTEXT | CRYPT_SILENT))


src/crypto/random.hpp

+
+	inline static prng& inst()
+	{
+		static thread_local prng inst;


tests/crypto/random.c


 #include "crypto-tests.h"

 void setup_random(void)
 {
-	memset(&state, 42, sizeof(union hash_state));
+	//memset(&state, 42, sizeof(union hash_state));


src/crypto/random.cpp

+
+void prng::start()
+{
+	hnd = new prng_handle;


src/crypto/random.cpp

+		std::abort();
+	}
+#endif
+	delete hnd;


Co-authored-by: cryptoseyed <cryptoseyed@gmail.com> Co-authored-by: omid-mmd <om.mo1375@gmail.com>

Create the cncrypto library two times, once for deamon and co and a special version with a deterministic random number generator for the crypto tests. - build a test library `cncrypto_for_test` - link crypto tests against `cncrypto_for_test`

add missing define guard

We use a new deterministic random number generator for the tests, therefore some hashes differ compared to the old tests. - update hashes those depends on the RNG - add documentation to the test to see where the RNG effects the hashes

src/crypto/random.cpp

+
+		while(size_bytes > 200)
+		{
+			buffer[0]++;


fireice-uk force-pushed the topic-new-prng branch from 8ea377b to 3945cf1 Compare August 14, 2018 15:34

fireice-uk requested a review from psychocrypt August 14, 2018 15:56

psychocrypt suggested changes Aug 14, 2018

View reviewed changes

psychocrypt reviewed Aug 14, 2018

View reviewed changes

src/crypto/random.cpp

void prng::start()

{

hnd = new prng_handle;

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

psychocrypt reviewed Aug 14, 2018

View reviewed changes

src/crypto/random.cpp Outdated

std::abort();

}

#endif

delete hnd;

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

fireice-uk force-pushed the topic-new-prng branch from 5bc5531 to 0e3b75d Compare August 15, 2018 12:28

fireice-uk and others added 6 commits August 19, 2018 12:06

Upgrade prng to c++

358e89a

Co-authored-by: cryptoseyed <cryptoseyed@gmail.com> Co-authored-by: omid-mmd <om.mo1375@gmail.com>

remove random_scalar test for now

3f535cd

add fixed prng

6276ce0

create two crypto libs

8b9cc15

Create the cncrypto library two times, once for deamon and co and a special version with a deterministic random number generator for the crypto tests. - build a test library `cncrypto_for_test` - link crypto tests against `cncrypto_for_test`

fix random.cpp

57094c5

add missing define guard

fix crypto tests

d75be9d

We use a new deterministic random number generator for the tests, therefore some hashes differ compared to the old tests. - update hashes those depends on the RNG - add documentation to the test to see where the RNG effects the hashes

fireice-uk force-pushed the topic-new-prng branch from 2215345 to d75be9d Compare August 19, 2018 11:07

psychocrypt reviewed Aug 19, 2018

View reviewed changes

src/crypto/random.cpp

while(size_bytes > 200)

{

buffer[0]++;

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

psychocrypt approved these changes Aug 20, 2018

View reviewed changes

psychocrypt added this to the 0.4.0.0/0.3.X.X milestone Aug 20, 2018

psychocrypt added the enhancement New feature or request label Aug 20, 2018

psychocrypt self-assigned this Aug 20, 2018

psychocrypt merged commit d763d3f into ryo-currency:dev Aug 20, 2018

psychocrypt mentioned this pull request Sep 8, 2018

release 0.3.1.0 #116

Merged

fireice-uk deleted the topic-new-prng branch September 9, 2018 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade prng to c++ #92

Upgrade prng to c++ #92

fireice-uk commented Aug 14, 2018 •

edited

Loading

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

Upgrade prng to c++ #92

Upgrade prng to c++ #92

Conversation

fireice-uk commented Aug 14, 2018 • edited Loading

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

This comment was marked as abuse.

fireice-uk commented Aug 14, 2018 •

edited

Loading