Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet fixes #94

Merged
merged 1 commit into from Aug 17, 2018
Merged

Wallet fixes #94

merged 1 commit into from Aug 17, 2018

Conversation

fireice-uk
Copy link
Member

Three fixes rolled into one:

  • Uninitialised access to m_wallet causing a crash
  • Extra security for hash_secret to prevent padding from screwing up key generation (default, 4, is ok)
  • Prompt user for the missing metadata if 12-word seed was used.

@fireice-uk fireice-uk added the bug Something isn't working label Aug 17, 2018
@psychocrypt psychocrypt added this to the 0.4.0.0/0.3.X.X milestone Aug 17, 2018
@psychocrypt psychocrypt self-assigned this Aug 17, 2018
@psychocrypt psychocrypt self-requested a review August 17, 2018 19:44
@psychocrypt psychocrypt merged commit 337b511 into ryo-currency:dev Aug 17, 2018
@psychocrypt psychocrypt mentioned this pull request Sep 8, 2018
Merged
@fireice-uk fireice-uk deleted the topic-wallet-fix branch September 9, 2018 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychocoderHPC psychocoderHPC psychocoderHPC approved these changes

@psychocrypt psychocrypt psychocrypt approved these changes

Assignees

@psychocrypt psychocrypt

Labels
bug Something isn't working
Projects
None yet
Milestone
0.3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fireice-uk @psychocoderHPC @psychocrypt