Include a query where the user can exclude trophies based on title #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@a2ys is attempting to deploy a commit to the ryo-ma's Team Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Jun 18, 2024
Closed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Can you write README? |
ryo-ma
approved these changes
Jul 3, 2024
|
@ryo-ma I updated the README. |
|
👍 |
ryo-ma
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to this repository.
This pull request adds a feature which helps the user exclude any trophy (or multiple trophies) they don't want to display by title.
For example,
This would exclude the trophy with the title Stars.
This would exclude the trophies with the title Stars and Followers.
This is similar to excluding trophies based on rank.
This pull request also addresses what might be the primary concern of the author in issue #272.
Also, I ran the following commands based off the CONTRIBUTING.md.
deno task lint deno task format deno task testdeno task testgave the following output, and passed the 9 tests.