Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protocol core to fix SKV4093GL connection problem #1092

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update protocol core to fix SKV4093GL connection problem #1092

wants to merge 1 commit into from

Conversation

StarterCraft
Copy link
Contributor

@StarterCraft StarterCraft commented Jul 4, 2021

SKV4093GL (aka STYTJ01ZHM aka dreame.vacuum.mc1808) connection problem was referenced first in #1066, later in #1086, and the working (as for me) fix was provided by @anonymous-one. Although @rytilahti suggested another way to fix this problem, I'd like to request to accept @anonymous-one's solution of the problem as the fastest one.

SKV4093GL (aka STYTJ01ZHM aka dreame.vacuum.mc1808) connection problem was referenced first in #1066, later in #1086, and the working (as for me) fix was provided by @anonymous-one. However @rytilahti [suggested](#1066 (comment)) another way to fix this problem, I'd like to request to accept @anonymous-one's solution of the problem as the fastest one.
@rytilahti
Copy link
Owner

As I mentioned earlier, I don't feel good about changing the id generation on that level as that might introduce problems on other devices that are currently working just fine.

One possible solution would be adding an interface to allow device implementations to define their own id generation logic, but it feels kludgy, too. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants