-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roborock: auto empty dustbin support #1188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @craigcabrey!
As we want to have some sort of feature flags at some point to allow downstreams to decide which features are supported, could you please add a guard if clause to check for the models supporting this feature prior to calling any of the methods? You could raise a VacuumException("Device does not support dustbin emptying")
or something similar when trying to run these commands on a non-supported devices.
That would be only the s7 and s7+ for the time being, I suppose?
9aedc53
to
65d6f85
Compare
Yea, that works. It's a little ugly but over time with a feature flag framework we could clean it up.
There is no S7+, just the S7. S7+ is a bundle of the S7 with the auto empty bin. |
Indeed, I have some code around locally, but I haven't yet figured out what's the best approach to make it generic among all supported devices. But this will do for now, it's fairly simple to replace that with something more generic when the time comes.
Ah, thanks for the clarification. This looks good to go as soon as the checks pass 👍 Please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready to be merged as soon as the checks pass 👍
addresses #1107
This is just an initial pass at this, probably more needs to be done. Will also look at the home assistant component.
Example CLI run: