Allow defining device_id for push server #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to allow defining the did for simulators Renames server_id to device_id to use consistent naming
rytilahti
added a commit
that referenced
this pull request
Jul 14, 2023
This fixes a regression introduced in #1710 where the device object was passed to the did_and_mac_for_model instead of the expected model name.
rytilahti
added a commit
that referenced
this pull request
Jul 14, 2023
This fixes a regression introduced in #1710 where the device object was passed to the did_and_mac_for_model instead of the expected model name.
rytilahti
added a commit
that referenced
this pull request
Jul 14, 2023
This fixes a regression introduced in #1710 where the device object was passed to the did_and_mac_for_model instead of the expected model name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to allow defining the did for simulators,
the device id is a better unique id than the mac address because it does not require working
miIO.infomethod:Renames server_id to device_id to use consistent naming