Fix broken miio-simulator start-up #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in #1710 where the device object was passed to the did_and_mac_for_model instead of the expected model name.
rytilahti
force-pushed
the
fix/miiosimulator_init
branch
from
4d05cee
to
ef11774
Compare
Codecov Report
@@ Coverage Diff @@
## master #1792 +/- ##
==========================================
- Coverage 80.70% 80.70% -0.01%
==========================================
Files 192 192
Lines 18510 18511 +1
Branches 4012 4012
==========================================
Hits 14939 14939
- Misses 3294 3295 +1
Partials 277 277
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #1710 where the device object was passed to the did_and_mac_for_model instead of the expected model name.
Fixes #1789