Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zhimi.airfresh.va4 support #795

Merged
merged 7 commits into from
Aug 28, 2020

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Aug 9, 2020

Fixes #791

@coveralls
Copy link

coveralls commented Aug 9, 2020

Coverage Status

Coverage increased (+0.07%) to 74.044% when pulling a1fd67c on syssi:feature/zhimi-airfresh-va4-support into db2cb9c on rytilahti:master.

@syssi syssi requested a review from rytilahti August 9, 2020 16:39
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a minor thing wrt. the max properties.

miio/airfresh.py Show resolved Hide resolved
Raw temperature VA2: 186 / 10.0
Raw temperature VA4: 18.6
@rytilahti rytilahti merged commit 425efb3 into rytilahti:master Aug 28, 2020
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
* Add zhimi.airfresh.va4 support

* Add tests

* Fix lint issues

* Add sample response and ntc temperature property

* Remove empty line

* Support different temperature formats

Raw temperature VA2: 186 / 10.0
Raw temperature VA4: 18.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xiaomi Smartmi Fresh Air System XFXTDFR02ZM. upgrade version of XFXT01ZM with heater.
3 participants