Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App doesn't work on latest python 3.11.1 #125

Closed
krakhimov opened this issue Dec 30, 2022 · 5 comments
Closed

App doesn't work on latest python 3.11.1 #125

krakhimov opened this issue Dec 30, 2022 · 5 comments

Comments

@krakhimov
Copy link

Python 3.11.1
pip 22.3.1

PS C:\Users\username> pip install python-songpal

PS C:\Users\username> songpal
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\username\scoop\apps\python\current\Scripts\songpal.exe\__main__.py", line 4, in <module>
  File "C:\Users\username\scoop\apps\python\current\Lib\site-packages\songpal\main.py", line 115, in <module>
    @coro
     ^^^^
  File "C:\Users\username\scoop\apps\python\current\Lib\site-packages\songpal\main.py", line 43, in coro
    f = asyncio.coroutine(f)
        ^^^^^^^^^^^^^^^^^
AttributeError: module 'asyncio' has no attribute 'coroutine'. Did you mean: 'coroutines'?
@rytilahti
Copy link
Owner

If you don't mind installing the git installation, could you try to see if that works? #121 should have fixed the issue but as no one reported back I was hesitant to make a release if that does not fix it...

@kdw2060
Copy link

kdw2060 commented Mar 17, 2023

Hi, i'd like to test this, but what should I do for 'installing the git installation', that's unclear to me.

@rytilahti
Copy link
Owner

Hi, just install it with pip like this:

pip install git+https://github.com/rytilahti/python-songpal.git

and you can then use the songpal command as usual. Thanks for testing :-)

@kdw2060
Copy link

kdw2060 commented Mar 17, 2023

The error message that krakhimov posted (and I had too) is gone indeed.

I still get another error when trying to discover my device, but I think that's probably due to my device not being supported anymore by Sony in the latest version of their api (STR-DN850).
ERROR:songpal.discovery:Unable to find X_ScalaerWebAPI_DeviceInfo

@rytilahti
Copy link
Owner

rytilahti commented Mar 17, 2023

Okay, that's unfortunate, thanks for testing and reporting back though :-( Btw, looks like they list that device also at https://vssupport.sony.net/en_ww/device.html as not supported.

I created a new release 0.15.2 so this issue can be closed now.

rytilahti added a commit that referenced this issue Nov 7, 2023
This release brings support for versioned method calls which are required by newer hardware, like TA-AN1000, thanks to @allistermaguire!

[Full Changelog](release/0.15.2...0.16)

**Implemented enhancements:**

- Add defining source-address for discover [\#133](#133) (@rytilahti)
- Add support for versioned methods used by newer devices [\#132](#132) (@allistermaguire)

**Closed issues:**

- Support for TA-AN1000 [\#130](#130)
- Support for SRS-XB23?  [\#127](#127)
- Apparently missing some dependency, bunch of errors [\#126](#126)
- App doesn't work on latest python 3.11.1 [\#125](#125)
- can't find the device [\#116](#116)

**Merged pull requests:**

- Use ruff for linting and formatting [\#139](#139) (@rytilahti)
- Configure to use CI as trusted publisher [\#137](#137) (@rytilahti)
- Drop importlib\_metadata dependency [\#136](#136) (@rytilahti)
- Drop Python 3.7 support [\#135](#135) (@rytilahti)
- Add updated devinfo with version info for HT-XT3 [\#134](#134) (@rytilahti)
- Add devinfo for STR-AZ5000ES receiver [\#129](#129) (@ohmantics)
@rytilahti rytilahti mentioned this issue Nov 7, 2023
rytilahti added a commit that referenced this issue Nov 7, 2023
This release brings support for versioned method calls which are required by newer hardware, like TA-AN1000, thanks to @allistermaguire!

[Full Changelog](release/0.15.2...0.16)

**Implemented enhancements:**

- Add defining source-address for discover [\#133](#133) (@rytilahti)
- Add support for versioned methods used by newer devices [\#132](#132) (@allistermaguire)

**Closed issues:**

- Support for TA-AN1000 [\#130](#130)
- Support for SRS-XB23?  [\#127](#127)
- Apparently missing some dependency, bunch of errors [\#126](#126)
- App doesn't work on latest python 3.11.1 [\#125](#125)
- can't find the device [\#116](#116)

**Merged pull requests:**

- Use ruff for linting and formatting [\#139](#139) (@rytilahti)
- Configure to use CI as trusted publisher [\#137](#137) (@rytilahti)
- Drop importlib\_metadata dependency [\#136](#136) (@rytilahti)
- Drop Python 3.7 support [\#135](#135) (@rytilahti)
- Add updated devinfo with version info for HT-XT3 [\#134](#134) (@rytilahti)
- Add devinfo for STR-AZ5000ES receiver [\#129](#129) (@ohmantics)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants