Fix leak of underlying data hash count #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by adding an Arc to the test struct and then checking the Arc's strong_count Tested with cargo test
underlying object leaks Tested with cargo test
The call to into_raw was leaking the increase in Arc count from the clone. Fix was to add the matching from_raw so the count decreases Tested with cargo test. Tests now pass again
|
This is horrible. Thanks for catching the bug and for the fix. |
ryzhyk
added a commit
that referenced
this pull request
Jul 16, 2020
Port memory leak fix (#5) to the 0.1 branch, which is still the most popular one on crates.io.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ArcIntern hash() function had to Arc::into_raw without a balancing Arc::from_raw
This PR