Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web theme should follow UI day/night color like before #644

Open
kaetemi opened this issue Sep 18, 2021 · 8 comments
Open

Web theme should follow UI day/night color like before #644

kaetemi opened this issue Sep 18, 2021 · 8 comments

Comments

@kaetemi
Copy link
Member

kaetemi commented Sep 18, 2021

Before:

image

Current:

image

nimetu> in css "-ryzom-modulate-color: true;" should work, and global_color attribute on input/img elements like before
@kaetemi kaetemi changed the title Web theme should follow UI color like before Web theme should follow UI day/night color like before Sep 18, 2021
@nimetu
Copy link
Contributor

nimetu commented Sep 18, 2021

I got old webig running and I think this should be correct result?
image

Well, either case I need to add '-ryzom-modulate-text-color' for text.

browser.css would need this then

* { -ryzom-modulate-color: true; }
img, input, a { -ryzom-modulate-color: false; }

@kaetemi
Copy link
Member Author

kaetemi commented Sep 18, 2021

Yup, except the darker background of the table cells should match the page background.

@nimetu
Copy link
Contributor

nimetu commented Sep 18, 2021

I thing I know what you mean, but I dont think its possible without manually changing table/td background to semi transparent.

First half in here has tr bgcolor as #333333d0 and #666666d0
image

@kaetemi
Copy link
Member Author

kaetemi commented Sep 19, 2021

Hmm. Not sure?

Opening the web in a 2006 client looks like this:
The cells match the background exactly. Not sure why it looks like a different shade in the current browser.

image

I'll check again with the latest changes.

@kaetemi
Copy link
Member Author

kaetemi commented Sep 19, 2021

This is with regular browser css

image

This is with the changes in browser css

* { -ryzom-modulate-color: true; }
img, input, a { -ryzom-modulate-color: false; }

image

@kaetemi
Copy link
Member Author

kaetemi commented Sep 19, 2021

Does the background and those triangles end up getting modulated twice, by any chance?

@nimetu
Copy link
Contributor

nimetu commented Sep 19, 2021

Ok I see the issue. If page background color is 333 and tr/td background color is 333, that tr/td should be invisible.
I think the issue is from drawing two overlapping quads with flush call between them.
Borders have same issue.

@nimetu
Copy link
Contributor

nimetu commented Sep 19, 2021

The issue is from "inner_thin_border" ingame template that also draws center rectangle.
I draw page background, flush, then draw rest of elements from xml.
inner_thin_border ends up between page and table background/borders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants