Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation to pushlish on PyPI #22

Closed
wants to merge 8 commits into from
Closed

Preparation to pushlish on PyPI #22

wants to merge 8 commits into from

Conversation

fabaff
Copy link

@fabaff fabaff commented Apr 11, 2019

To be able to pushlish arjun on PyPI it's required to have a different structure.

The changes in detail:

  • Make it a package (move to arjun)
  • Move parts out of __main__.py (former arjun.py)
  • Add setup.py file and allow to run the tool with arjun instead of python3 arjun.py ...
  • Add setup.cfg file
  • Start to collect contants at one location
  • Update README
  • Fix typos in README
  • Follow PEP8 (with black) and PEP257

@s0md3v
Copy link
Owner

s0md3v commented Apr 12, 2019

Thanks for submitting the pull request but I have no plans of uploading it to pypi.
I feel bad that you had to work on it and I am sorry for the same.
Thanks again.

@s0md3v s0md3v closed this Apr 12, 2019
@fabaff
Copy link
Author

fabaff commented Apr 12, 2019

Yeah, that's the reason why I added myself as maintainer for PyPI.

Providing a setup.py file is how Python tools are handled in an easy way by users and when it comes to packaging tools for distributions. In the current state all future package maintainers have to jump to hoops.

@s0md3v s0md3v reopened this Apr 24, 2019
@s0md3v
Copy link
Owner

s0md3v commented Apr 24, 2019

Hi @fabaff ,

Resolve the conflicts and we are ready to merge.
Sorry for the inconvenience.

Thanks for the contribution.

@fabaff
Copy link
Author

fabaff commented Jul 22, 2019

What's the hold-up? I fixed the conflicts two months ago and now there are again some...

@s0md3v s0md3v closed this in 19882f1 Oct 23, 2019
@fabaff
Copy link
Author

fabaff commented Oct 23, 2019

Why was this closed?

This was referenced Nov 18, 2019
@s0md3v s0md3v reopened this Nov 19, 2019
@s0md3v s0md3v added enhancement New feature or request priority labels Nov 19, 2019
@fabaff
Copy link
Author

fabaff commented May 26, 2020

This is now blocking the inclusion of osmedeus into the Fedora Package Collection...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants