Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved (?s) to flags=re.S because it's a global flag #382

Closed
wants to merge 1 commit into from
Closed

Moved (?s) to flags=re.S because it's a global flag #382

wants to merge 1 commit into from

Conversation

ligix
Copy link

@ligix ligix commented Aug 5, 2023

What does it implement/fix? Explain your changes.

Global flags aren't allowed not at the start of the regex

Where has this been tested?

Python Version: 3.11.3
Operating System: Arch Linux

Does this close any currently open issues?

#372 #376 #377

Does this add any new dependency?

no

Does this add any new command line switch/option?

no

Any other comments you would like to make?

no

Some Questions

  • I have documented my code.
  • I have tested my build before submitting the pull request.

@kejcao
Copy link

kejcao commented Oct 9, 2023

Thank you! I had the same issue.

@ligix ligix closed this by deleting the head repository Jan 20, 2024
@ACE-Optic
Copy link

What does this mean for the parameters, I keep getting the same issue as the person in #372 and I assume that is because ?'s are not the correct parameter anymore, but what would be then?

@ligix
Copy link
Author

ligix commented Mar 4, 2024

What does this mean for the parameters, I keep getting the same issue as the person in #372 and I assume that is because ?'s are not the correct parameter anymore, but what would be then?

if only there was an easy way to convey what should be changed in an easy to read and easy to merge way....

screenshot of the PR contents

I didn't close this PR because it's somehow wrong, I just deleted my fork.

screenshot of "user closed this by deleting the head repository"

@Nxctu
Copy link

Nxctu commented Mar 12, 2024

I don't understand, it works for me, why is it not merget yet ?

@ligix
Copy link
Author

ligix commented Jun 1, 2024

I don't understand, it works for me, why is it not merget yet ?

The last commit on this repo was Mar 20, 2022, it's no longer maintained

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants