Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Knife back stab multiplier customizable #834

Merged
merged 6 commits into from Jul 1, 2023

Conversation

dystopm
Copy link
Contributor

@dystopm dystopm commented May 19, 2023

title

Feature addition, plus a few line changes, up to modders preferences.

@StevenKal
Copy link
Contributor

StevenKal commented May 20, 2023

Write the whole word ("*iplier")!
+
Add the define "REGAMEDLL_ADD".

@dystopm
Copy link
Contributor Author

dystopm commented May 20, 2023

Write the whole word ("*iplier")! + Add the define "REGAMEDLL_ADD".

Thanks you for your observation. I did not add the REGAMEDLL_ADD macro because the written CKnife modification members, the ones preceded by m_flStab/m_flSwing, were not programmed under the above clauses, so I did a wild guess by just extending it. That should be reviewed by the repo maintainers. What do you think?

About the Mult suffix, it is between unnecessary but sane, so I'll wait for someones commentary about it. If you have anything else to add I'll be glad to see it.

@StevenKal
Copy link
Contributor

StevenKal commented May 21, 2023

Thanks you for your observation. I did not add the REGAMEDLL_ADD macro because the written CKnife modification members, the ones preceded by m_flStab/m_flSwing, were not programmed under the above clauses, so I did a wild guess by just extending it. That should be reviewed by the repo maintainers. What do you think?

Yeah knowing this maybe it can be skipped & so not added, or, added from "m_flStabBaseDamage" if they decide to.
Do not have too much hope about approvers reviewing & approving anything...

About the Mult suffix, it is between unnecessary but sane, so I'll wait for someones commentary about it. If you have anything else to add I'll be glad to see it.

I recommend it, a proper & complete name does not hurt!

- Added forgotten macros to last commit that included members used mostly on API
- Added inline functions for specific values, considering original and new behaviour
- Mult -> Multiplier
@dystopm
Copy link
Contributor Author

dystopm commented Jun 30, 2023

Write the whole word ("*iplier")! + Add the define "REGAMEDLL_ADD".

I ended adding what you wrote here :)

@s1lentq some sort of possibility to check this out, and some future ones? Got time for editing and extending this repo

@s1lentq s1lentq merged commit 12560c2 into s1lentq:master Jul 1, 2023
4 checks passed
@dystopm dystopm deleted the knife-backstab-member branch July 1, 2023 06:49
@RauliTop
Copy link
Contributor

RauliTop commented Jul 3, 2023

@dystopm
Do we need to add these new members on ReAPI include??

@dystopm
Copy link
Contributor Author

dystopm commented Jul 3, 2023

@dystopm Do we need to add these new members on ReAPI include??

Thing is, ReAPI module should be edited and add the last member added to the member table, it isn't enough with editing the include. In other hand, Minor version should be updated in both ReGameDLL and ReAPI, so you can track changes correctly. There are plenty of API upgrades as pull requests so it depends of repo maintainers to merge one of these and update minor version, forcing ReAPI to be updated also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants