Dynamically determine whether lseek extended options are supported #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
#1354
Details
This PR is a code to avoid that s3fs cannot be built when whence SEEK_HOLE/SEEK_DATA of the lseek function is undefined.
Also, in the runtime environment where lseek cannot recognize these whence, s3fs will not start up with an error if the set_check_cache_sigusr1 option is specified.
This fix will broaden the build and run environments.
However, I think that we do not want to change the target OS supported by s3fs by this fix does.
The environment that can be built/executed is increase to wide, but the OS environment that can be officially supported follows the contents discussed in #1354.