Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed option processing to use strtol() to get a umask #83

Merged
merged 1 commit into from
Nov 16, 2014

Conversation

tmwong2003
Copy link

get_mode()/s3fs_strtoofft() does not handle octal umask values, which
results in unexpected behavior when trying to set a world-readable umask
value.

get_mode()/s3fs_strtoofft() does not handle octal umask values, which
results in unexpected behavior when trying to set a world-readable umask
value.
@tmwong2003
Copy link
Author

Incidentally, why does s3fs use a home-grown parser method strtoofft() instead of strtol() from cstdlib to convert decimal, octal, and hexadecimal strings to longs?

ggtakec added a commit that referenced this pull request Nov 16, 2014
Changed option processing to use strtol() to get a umask
@ggtakec ggtakec merged commit 082eb24 into s3fs-fuse:master Nov 16, 2014
@ggtakec
Copy link
Member

ggtakec commented Nov 16, 2014

Thank you.
I was using conventionally, called a function that has been mainly used in part of other than this problem also on the parameters of the umask in s3fs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants