Human Readable URLs #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flakey because of system clock seeding
Sync with s3krit/file0
Sync with master
|
Looks good, cheers. I'd like it to be a configurable (add some boolean or something to |
Gravedigging: Added a config option to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #19
Adds Gfycat-style URL generation consisting of a concatenated string of capitalized words. The default format is "AdjectiveAdjectiveNounNoun".
The generator supports adding additional word lists and formats.
In testing a large number of generated phrases I did see conflicts starting after around 3,000,000 generated phrases, but for an application like file0 where there is relatively low traffic / file expiration I'm not particularly concerned.