Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fp16 in downstream/runner.py #465

Open
GiscardBiamby opened this issue Mar 3, 2023 · 2 comments
Open

Enable fp16 in downstream/runner.py #465

GiscardBiamby opened this issue Mar 3, 2023 · 2 comments

Comments

@GiscardBiamby
Copy link
Contributor

Feature request

Is your feature request related to a problem? Please describe.
Downstream fine-tuning can run faster and use less GPU memory if fp16 is enabled in downstrean/runner.py. It is already implemented in upstream/runner.py.

It should not affect any existing code since fp16 is off by default in the downstream configs. Users would opt-in by setting runner.fp16: true in their downstream configs.

Describe the solution you'd like
Mimic the implementation of mixed precision training from upstream/runner.py in downstream/runner.py

Describe alternatives you've considered
None

Additional context
I've implemented locally so I'm happy to send a PR if you would like.

@leo19941227
Copy link
Member

Hello!

Sure! This sounds excellent.
Could you send the PR? I can test and merge it today.
Thanks!

leo19941227 added a commit that referenced this issue Sep 26, 2023
Add fp16 support to downstream/runner.py fixing #465
@AdamGradient
Copy link

I'm just curious. In your previous experiments, did you find this to have an evident impact on performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants