Adding tabs #2
Merged
Adding tabs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created Interleaved reader and writer
|
Tabs and Interleaved now. Someone mind looking over it before it goes into master? |
| void output_read_map_tab(const BitMap& read_map, T& out1) { | ||
| OutputWriter<ReadBase, ReadBaseOutTab> tabs(out1); | ||
| for(auto const &i : read_map) { | ||
| ReadBase* rb = dynamic_cast<ReadBase*>(i.second.get()); |
There was a problem hiding this comment.
no need to dynamic cast here, bitmap has readbases in it.
|
Yeah looks good dude, just a couple minor comments. |
| @@ -62,8 +62,8 @@ template <class T> | |||
| void output_read_map_tab(const BitMap& read_map, T& out1) { | |||
| OutputWriter<ReadBase, ReadBaseOutTab> tabs(out1); | |||
| for(auto const &i : read_map) { | |||
| ReadBase* rb = dynamic_cast<ReadBase*>(i.second.get()); | |||
| tabs.write(*rb); | |||
| //ReadBase* rb = dynamic_cast<ReadBase*>(i.second.get()); | |||
|
looks good other than comment |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.