Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all build plug-in dependencies to the artifacts list whenever build plugins are validated #56

Merged
merged 4 commits into from
Dec 24, 2019

Conversation

cobratbq
Copy link
Contributor

Add dependencies of build plug-ins as well as the build plug-ins themselves to the artifact validation list. (#54)

Given an earlier discovery that maven does not accept Version Range specification for build plug-in dependencies, it is trivial to add plug-in dependency artifacts: there is no need for version conflict resolution.

@slawekjaranowski let me know if you really want to add this under another configuration switch. Right now this would be included as soon as build plug-ins are included. (Personally, I would like to avoid it.)

@cobratbq
Copy link
Contributor Author

I need to confirm if this dependencies list is a transitive closure (includes dependencies of dependencies). I think it is not. Even if it is not, this already adds value due to direct dependencies being verified, but in any case, it is good to understand the full scope of the validation.

@slawekjaranowski
Copy link
Member

It will be good have at least one IT test to confirm it, or extends assertions in one existing test

@cobratbq
Copy link
Contributor Author

You're right. I was finishing up when I found out that I missed something. I'll close it for now to avoid confusion.

@cobratbq cobratbq closed this Dec 20, 2019
@cobratbq cobratbq reopened this Dec 23, 2019
@cobratbq
Copy link
Contributor Author

@slawekjaranowski I've updated the IT test to check for plug-in dependencies too.

How do you feel about leaving TODO comments in the code where the implementation is not complete yet? (That is, complete as in, there is room to extend the functionality.) I'm hestitant to start extensive research on how Maven might perform dependency tree resolution for build plug-ins.
If you don't like it, how would you want to mark future work/room for improvement?

@slawekjaranowski slawekjaranowski merged commit 03695f0 into s4u:master Dec 24, 2019
@cobratbq cobratbq deleted the validate-plugin-dependencies branch December 26, 2019 23:06
@slawekjaranowski slawekjaranowski added this to the v1.6.0 milestone Jan 14, 2020
pzygielo pushed a commit to pzygielo/pgpverify-maven-plugin that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants