Proper pull request #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this instead of just `ticker()[market]` doesn't make much sense and one should really be doing 'tick = ticker()' then `tick[market1], tick[market2]` so you aren't making extra api calls for information you already have.
Use GET for public commands instead of POST # Conflicts: # poloniex/__init__.py
|
yup, that fixes the conflicts thanks for the extra work. I probably could of done it on my end under normal circumstances. Ill make a release as soon as i can get to a proper keyboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks very messy as I am still getting used to the more advanced git features. Synced with upstream and added my commits to fix the previous issue. Future pull requests will be cleaner.