Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mapjs/src/browser/dom-map-widget.js: Using deprecated keyCode within document listener #3

Open
s6mike opened this issue Oct 10, 2022 · 2 comments
Open

mapjs/src/browser/dom-map-widget.js: Using deprecated keyCode within document listener #3

s6mike opened this issue Oct 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@s6mike
Copy link
Owner

s6mike commented Oct 10, 2022 •
edited
Loading

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

https://beta.workflowy.com/#/b3ab0251f2e5
@s6mike s6mike added the enhancement New feature or request label Oct 10, 2022
@s6mike s6mike changed the title mapjs/src/browser/dom-map-widget.js: Using deprecated keyCode within document listener: fix mapjs/src/browser/dom-map-widget.js: Using deprecated keyCode within document listener Oct 10, 2022
@s6mike
Copy link
Owner Author

s6mike commented Oct 10, 2022

mapjs/src/browser/dom-map-widget.js: 190

Also see: #4

s6mike added a commit to s6mike/argmap that referenced this issue Oct 12, 2022
@s6mike
4.9.6 fix(mapjs): Fix zoom keyboard shortcuts:
f4a70f4 
    - mapjs/src/browser/dom-map-widget.js`: Fix zoom keyboard shortcuts:
      - Now using keyCode, instead of keyIdentifier which didn't work.
      However, keyCode is deprecated: ISSUE s6mike/mapjs#3
      - Add 2 missing key codes.
@s6mike
Copy link
Owner Author

s6mike commented Dec 17, 2022

Should use KeyboardEvent.key instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s6mike