Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
References #148
- Loading branch information
Showing
2 changed files
with
17 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d15c4c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a param to get a file from the templates directory, like the comment says, if serendipity_getTemplateFile always gets files from the template directory?
If I understand the code right, this is about getting a file in the backend from the frontend-template. This is valid, but not what the comment says.
But how this is used in the end is strange. Why would you get something from the admin-part of the frontend-template? How can this be reliable?
d15c4c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d15c4c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d15c4c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Garvin
This is the part that is strange for me. The user should just set his forked template as his admin template. Then s9y should use his files first and fall back to 2k11 for everything else. This is the part where I choose not to be involved in the ckeditor-discussion, but I don't like it at all that we introduce this uncommon behaviour just for that. It is not necessary, it should always be part of the admin template, and that function is just too central - for such a change before the RC, and for such an exception for such a small cause.
I needed days and several iterations to get the fallback chain working properly, it is just seems crazy to me to doctor with her now, toggled or not, and to introduce behaviour we already now is unstable.
d15c4c8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.