Media button in non-WYSIWYG editor (again)

[th-h]

2.0-beta3 on Firefox 31.0
See http://board.s9y.org/viewtopic.php?f=3&t=19861
See 62026e5 and #121, #143, #145.

The media button ("Mediendatenbank") does not pick up changes to the setting of "no link / add link to ..." (in German: "Das Bild soll kein Link sein" / "Das Bild soll hierhin linken: ...") immediately; it will change only the second time you insert an image. What's more, if you switch the setting back and forth, it will always insert an image with the setting you had set one image before. It seems the saved/cached setting is "out of step".

All other settings can (now) correctly be changed.

In beta2, it did work even less: changes were never executed. See the referenced commit (which did not completely fix it, as it seems) and the referenced issues.

Steps to reproduce:

1. Use the media button ("Mediendatenbank") in the non-WYSIWYG editor to add a picture.
2. Select "preview" ("Ich möchte die Vorschau im Eintrag haben."), center alignment and a link to the larger picture ("Das Bild soll hierhin linken: ...).
3. S9y will insert the necessary code, according to your settings.
4. Use the media button ("Mediendatenbank") in the non-WYSIWYG editor to add another picture.
5. This time, change all three settings. Select "large image" ("Ich möchte das große Bild im Eintrag haben."), left aligned and no link ("Das Bild soll kein Link sein").
6. S9y will insert the necessary code and change the first two settings, but not the third: you'll get the large picture, left aligned, but with a link
7. Use the media button again to insert the same picture. Do not change any setting; you'll see that your last choices - even concerning "no link" - have been saved.
8. This time, s9y will honor all settings: you'll get the large picture, left aligned, and no link.
   You can switcht that back and forth as you like; changes to picture size (preview / large picture) and alignment will be picked up immediately, changes to link/no link will always need to tries.
9. Now insert an image and switch the setting back to "with link". S9y will insert an image without link, as already tested.
10. Now insert an image again and switch the setting once again to "no link". S9y will insert an image with a link, as you requested one step before.
11. Just inerst an image again and once again switch back to "with link". S9y will now insert an image without a link, as requested one step before.

It doesn't matter if you use the same image or other images, and it doesn't matter if you edit (or create) the same entry or multiple entries.

[onli]

We asked wrongly for the value of that setting. 9b63c41 should fix it, could you try it out? I saw correctly that this is the only setting that didn't work on the first run?

[th-h]

Yes, that was the only setting not working on the first run.
Yes, again it's working now (in f7da641, which I have checked out to test it).

Thanks!