Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubling entries #340

Closed
ddeimeke opened this issue Apr 20, 2015 · 12 comments
Closed

Doubling entries #340

ddeimeke opened this issue Apr 20, 2015 · 12 comments
Labels
Milestone

Comments

@ddeimeke
Copy link

Unfortunately, I have no clue how to reproduce the behaviour. Sometimes I write an article and save (and publish) it, after a few moments I edit something in the article that I forgot and I end up with two (published) articles.

This happens either with drafts and with published ones.

Any idea where this comes from? Autosave?

Serendipity 2.1-alpha1, PHP 5.4.16

@yellowled yellowled added this to the 2.0.x milestone Apr 20, 2015
@ddeimeke
Copy link
Author

I can reproduce it exactly the way described before.

Write an article, save it, keep the edit window open, do some changes and save it again.

@onli
Copy link
Member

onli commented Apr 20, 2015

That should be caused by a javascript error after saving the entry that prevents the id to be set, this code:

<script type="text/javascript">$(document).ready(function() {

Next time this happens, could you check your browser js console for errors?

@ddeimeke
Copy link
Author

I will try to remember. The problem is, that I only find out about duplicate entries once I click on "edit entries".

@yellowled
Copy link
Member

@ddeimeke This has been open for almost two months now – did you remember to reproduce what @onli suggested?

@ddeimeke
Copy link
Author

Yes, I tried to, but I never saw the duplicate entry directly after I saved an article. I only recognized them after publishing. In my opinion, the combination of autosave and preview create this issue.

@yellowled
Copy link
Member

Xmas issue cleanup – this issue has been open, but without interaction for a while now. Is it still an issue? Has anyone tested or reproduced it? Should/can we close it?

@ddeimeke
Copy link
Author

I did not see this behavior for a while now. Maybe you close the issue and I open a new one, once it occurs.

@yellowled
Copy link
Member

Makes perfect sense. 👍

@ddeimeke ddeimeke reopened this Apr 23, 2016
@onli
Copy link
Member

onli commented Apr 23, 2016

It occurred again.

I still can't reproduce it in my blog, test or otherwise, but we found a plan how to solve this: The moment the "Create new entry" is generated create a new entry with a proper id. The new part of this is that we could get rid of the javascript which sets the id of the newly generated into the entry editor id. But it is potentially complicated codewise. Investigate.

@yellowled
Copy link
Member

@onli Shouldn't this be fixed by the recent changes we made to the backend preview or is this unrelated to the preview?

@onli
Copy link
Member

onli commented Sep 13, 2016

Not unrelated, as it is caused by the JS in the save iframe not working properly. Removing the backend JS could help to reduce this, but fully solved it would only be if we follow the plan described in #340 (comment), or if we find a better solution.

@garvinhicking
Copy link
Member

(Should hopefully be fixed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants