Fix prev/next page links for stable archives. #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't swap prev/next links for archive pages. With stable archives, the title page is the last page of the archive, not the first, so all other pages are "previos", and we should display it like that. That may seem counterintuitive at first, but otherwise archive page directions and pagination directions don't match (see bulletproof), and we shouldn't count archive pages differently from the URL. With the current code, page 100 of 100 archive pages would be shown in footer_info as page 1, page 99 as page 2, and that doesn't make sense either. Signed-off-by: Thomas Hochstein <thh@inter.net>
th-h
added
the
backport needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't swap prev/next links for archive pages. With stable archives, the title page is the last page of the archive, not the first, so all other pages are "previos", and we should display it like that.
That may seem counterintuitive at first, but otherwise archive page directions and pagination directions don't match (see bulletproof), and we shouldn't count archive pages differently from the URL. With the current code, page 100 of 100 archive pages would be shown in footer_info as page 1, page 99 as page 2, and that doesn't make sense either.
Signed-off-by: Thomas Hochstein thh@inter.net