Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prev/next page links for stable archives. #628

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@th-h
Copy link
Member

th-h commented Aug 16, 2019

We shouldn't swap prev/next links for archive pages. With stable archives, the title page is the last page of the archive, not the first, so all other pages are "previos", and we should display it like that.

That may seem counterintuitive at first, but otherwise archive page directions and pagination directions don't match (see bulletproof), and we shouldn't count archive pages differently from the URL. With the current code, page 100 of 100 archive pages would be shown in footer_info as page 1, page 99 as page 2, and that doesn't make sense either.

Signed-off-by: Thomas Hochstein thh@inter.net

We shouldn't swap prev/next links for archive
pages. With stable archives, the title page is
the last page of the archive, not the first, so
all other pages are "previos", and we should
display it like that.

That may seem counterintuitive at first, but
otherwise archive page directions and pagination
directions don't match (see bulletproof), and we
shouldn't count archive pages differently from
the URL. With the current code, page 100 of 100
archive pages would be shown in footer_info as
page 1, page 99 as page 2, and that doesn't make
sense either.

Signed-off-by: Thomas Hochstein <thh@inter.net>
@th-h th-h merged commit 6253c03 into s9y:master Aug 16, 2019
@th-h th-h deleted the th-h:thh-pagination branch Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.