PHP 8.0 compatibility fixes for the frontend #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used in 2k11 for PHP 8 compatibility checks
This throws an error with PHP 8, but since $week is never defined it looks like this has been broken for a while. It can be re-added in a separate PR, if the intended functionality is known.
onli
commented
Mar 16, 2021
onli
commented
Mar 16, 2021
onli
commented
Mar 16, 2021
onli
commented
Mar 16, 2021
Parts of VIEWMODE_THREADED remained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do
Fixes several compatibility issues that prevented serendipity's frontend from working with PHP 8.0. Test scenario is a not logged in visitor browsing through my development blog.
Notes
This is a follow up to #750, a smaller and easier to review slice of that PR without the backend compatibility changes.