-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spiked Bucklers Defense is not used by the BC #291
Comments
from attacks.py line 600 how are defenses inconsistently formatted? |
When given in the stat field, defenses are formatted thus:
But as a bracketed trait in the text field, they are like: It is a fairly minor difference (the lack of an |
Ok I will fix that, but it still doesn't explain the issue with the Buckler... |
@ACG8 I am not able to see if Enchantment based Defenses are still working as I cant get them to attach to either the Mage or the Orc Butcher. I am checking in what I have including my debug messages so you can see where I have been looking. |
I found the issue with the buckler's code. In the xml file, the defense was defined in the stats field, as it would be for a creature defense. However, since it is a trait granted by the equipment, it should be in the text field. I should have fixed this ages ago. I'm sorry for the delay. |
Yes that fixes that particular item. But once again, we have this line for Defense=8+ 1x No Ranged, Armor=0, Life=4 So why does it work there but not for the Spiked Buckler's: Location=Shield, Defense=8+ 1x No Ranged For V2 when I was testing Defenses were not working at all. //FC On Fri, Dec 18, 2015 at 5:25 PM, Ananda notifications@github.com wrote:
|
Because in the Bobcat's case, the defense is part of its stats. In the Buckler's case, the defense is a stat that it grants to your mage, not a stat of the shield. It is in the wrong xml field. The way defenses work in V1 is that innate defenses are coded in the stats xml field and defenses granted to the target creature are coded in brackets in the text xml field. |
Working now, there are more bugs to cover but this issue is done. |
No description provided.
The text was updated successfully, but these errors were encountered: