Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TXT records #142

Merged
merged 5 commits into from
Sep 29, 2017
Merged

Allow TXT records #142

merged 5 commits into from
Sep 29, 2017

Conversation

creideiki
Copy link
Contributor

Update palletjack2zones to allow TXT records to be specified in the warehouse and output to the zone.

Closes #130.

@creideiki creideiki mentioned this pull request Sep 23, 2017
Open
notCalle
notCalle suggested changes Sep 26, 2017
View reviewed changes
Copy link
Contributor

@notCalle notCalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be reasonably DRY.

examples/warehouse/domain/example.com/dns.yaml Outdated
@@ -23,3 +23,8 @@ net:
protocol: tcp
port: 5269
target: xmpp2
txt:
- label: example.com.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeating the domain FQDN as label is not DRY, i think we should use explicit YAML ~ or leave the label unspecified to specify a "null" label.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A ~ shows up as an empty string (which is probably yet another part of #135), but leaving the label unspecified works.

tools/lib/palletjack2zones.rb Outdated
if domain['net.dns.txt']
domain['net.dns.txt'].each do |record|
txt = DNS::Zone::RR::TXT.new
txt.label = record['label']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

|| absolute_domain_name

@notCalle notCalle merged commit 664eea4 into saab-simc-admin:master Sep 29, 2017
notCalle added a commit that referenced this pull request Sep 29, 2017
@notCalle
Merge pull request #142 from creideiki/txt-records-130
8deb18b 
* 664eea4 Raise more RuboCop metrics limits exceeded by pj2zones
* 03de584 Allow omitting label for domain-attached TXT records
* 9266f2c Add TXT records and documentation to example warehouse
* 9fdb1af Raise RuboCop metrics limits exceeded by pj2zones
* 23551a5 Output TXT records in pj2zones
@creideiki creideiki deleted the txt-records-130 branch September 29, 2017 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notCalle notCalle notCalle approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@creideiki @notCalle