Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical steps bar is misaligned when a height is applied #279

Closed
GaelLnz opened this issue Nov 1, 2021 · 2 comments
Closed

Vertical steps bar is misaligned when a height is applied #279

GaelLnz opened this issue Nov 1, 2021 · 2 comments
Assignees
@GaelLnz
Labels
step

Comments

@GaelLnz
Copy link
Contributor

GaelLnz commented Nov 1, 2021

When you set a specific height for a vertical step element, the vertical step bar becomes misaligned.

Current behavior

View on Tailwind play
image

Expected behavior

image

Fix

Apply -translate-y-1/2 instead of margin-top: -100%; on .steps-vertical .step:before

I would love to fix it myself and become a contributor of daisyUI :)
@saadeghi
Copy link
Owner

saadeghi commented Nov 1, 2021

@GaelLanez Sure. Here's the file to edit
Can you open a PR?

@GaelLnz
Copy link
Contributor Author

GaelLnz commented Nov 1, 2021

Thank you @saadeghi
Yes I will.

saadeghi added a commit that referenced this issue Nov 1, 2021
@saadeghi
Merge pull request #282 from GaelLanez/fix-vertical-steps
42608ee 
fix: #279 - Vertical steps resize to content
@saadeghi saadeghi added the step label Feb 24, 2022
inorganik pushed a commit to inorganik/daisyui that referenced this issue Feb 7, 2023
@GaelLnz
fix: saadeghi#279 - Vertical steps resize to content
bc9102c
inorganik pushed a commit to inorganik/daisyui that referenced this issue Feb 7, 2023
@saadeghi
Merge pull request saadeghi#282 from GaelLanez/fix-vertical-steps
1a71825 
fix: saadeghi#279 - Vertical steps resize to content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GaelLnz GaelLnz

Labels
step
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saadeghi @GaelLnz