Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change FBSDKCoreKit to 11.0.0 #4

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Conversation

Ciock
Copy link
Contributor

@Ciock Ciock commented Jun 23, 2021

Reference Issues/PRs

None

What does this implement?

Upgrade FBSDKCoreKit to 11.0.0 to be compatible with:
flutter_facebook_auth 3.4.1

@vishwarajanand
Copy link

Is this tested?

@Ciock
Copy link
Contributor Author

Ciock commented Jul 21, 2021

What do you mean by test? I don't see any automated tests in the repository.

If you mean if I've tried it firsthand, yes, I use this branch in a released app.

@knightowlRaising
Copy link

It's not reflecting on Facebook dev console that the new version is updated! Are you sure only that line of code needed to be upgraded nothing else?

@Ciock
Copy link
Contributor Author

Ciock commented Jul 22, 2021

No, i'm not sure.

@jjsebastianfuertes
Copy link

is there a reason this has not been merged yet?

@cassiosousa
Copy link

@Ciock, Do you know if this PR fix this issue #9 ?Can you get test?

@Ciock
Copy link
Contributor Author

Ciock commented Oct 1, 2021

I don't think it's related to that issue, but i don't remember exactly what error i run into.

Anyway i'm still using my fork with this upgrade, you can try it and see if it fix the issue.

flutter_facebook_sdk:
    git:
      url: https://github.com/Ciock/flutter_facebook_sdk
      ref: master

@saadfarhan124 saadfarhan124 merged commit 8b333fe into saadfarhan124:master Nov 6, 2021
AlexSheiko pushed a commit to AlexSheiko/flutter_facebook_sdk that referenced this pull request Jul 10, 2023
add basic app events log "Schedule", "SubmitApplication"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants