Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure the branch name #39

Closed
jmlemetayer opened this issue Nov 2, 2022 · 2 comments · Fixed by #40 or #55
Closed

Allow to configure the branch name #39

jmlemetayer opened this issue Nov 2, 2022 · 2 comments · Fixed by #40 or #55
Labels
enhancement New feature or request

Comments

@jmlemetayer
Copy link
Contributor

I have configured the version updater action on my project and it works perfectly. Thanks for your project.

But as it is executed every day and with a new branch name each time, if I don't check my projects every day, I end up with several pull requests for the same patch.

On my workflow:

on:                                                                                                                                                                                                            
  schedule:                                                                                                                                                                                                    
    - cron: '0 0 * * *'

On main.py :

new_branch_name = f"gh-actions-update-{int(time.time())}"

I think it will be good to have a fix branch name (at least as an option), So that the pull request can be updated each time (with a force push).

Best regards,
Jean-Marie

@saadmk11 saadmk11 added the enhancement New feature or request label Nov 2, 2022
@jmlemetayer
Copy link
Contributor Author

Hi @saadmk11,

As said in my comments of #40, I have tested the test branch on my project and it is working well.

Looks good to me, I am waiting for you to merge it to the main branch.

Best regards and happy new year.

@saadmk11
Copy link
Owner

saadmk11 commented Jan 2, 2023

@jmlemetayer Thanks for the reminder. I still did not get a chance to test it out. I will try to release this sometime next week. Meanwhile you can use the pr-branch-config branch if this a urgent requirement for your workflow. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants