You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we have an instance of SelectedIds per source and per mode.This was initially introduced to enforce only one active (selected) id in the merge/split mode. However, having id selection per mode is highly counterintuitive for users. Also, programming logic is much simpler with one SelectedIds per source. I suggest:
Use only one instance of SelectedIds.
Introduce a new state, e.g. lastClicked that records the fragment id that was last activated (or Label.INVALID if deactivated)
use lastClicked to determine which fragment id should be used for merge/split.
enable multiple active fragments in merge/split mode (maybe unify with highlights mode).
introduce new highlighting mode for lastClicked, e.g. pulsating between INVALID and actual color
The text was updated successfully, but these errors were encountered:
Fixed with the merge of #65/#85
If there is a need for highlighting the last selection (the last bullet point in the initial comment) we should create a separate issue for that.
Currently, we have an instance of
SelectedIds
per source and per mode.This was initially introduced to enforce only one active (selected) id in the merge/split mode. However, having id selection per mode is highly counterintuitive for users. Also, programming logic is much simpler with oneSelectedIds
per source. I suggest:SelectedIds
.lastClicked
that records the fragment id that was last activated (orLabel.INVALID
if deactivated)lastClicked
to determine which fragment id should be used for merge/split.lastClicked
, e.g. pulsating betweenINVALID
and actual colorThe text was updated successfully, but these errors were encountered: