Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only one instance of SelectedIds per source #63

Closed
hanslovsky opened this issue Jan 29, 2018 · 2 comments
Closed

Use only one instance of SelectedIds per source #63

hanslovsky opened this issue Jan 29, 2018 · 2 comments

Comments

@hanslovsky
Copy link
Contributor

Currently, we have an instance of SelectedIds per source and per mode.This was initially introduced to enforce only one active (selected) id in the merge/split mode. However, having id selection per mode is highly counterintuitive for users. Also, programming logic is much simpler with one SelectedIds per source. I suggest:

  • Use only one instance of SelectedIds.
  • Introduce a new state, e.g. lastClicked that records the fragment id that was last activated (or Label.INVALID if deactivated)
  • use lastClicked to determine which fragment id should be used for merge/split.
  • enable multiple active fragments in merge/split mode (maybe unify with highlights mode).
  • introduce new highlighting mode for lastClicked, e.g. pulsating between INVALID and actual color
@hanslovsky
Copy link
Contributor Author

https://github.com/hanslovsky/bigcat/tree/fix-neuron-mesh-generation integrates most of these suggestion with the exception of lastClicked and pulsating highlights that are in a more experimental branch at https://github.com/hanslovsky/bigcat/tree/highlight-last-selection

A pull request, at least for the former, will follow soon.

This was referenced Jan 29, 2018
@hanslovsky
Copy link
Contributor Author

Fixed with the merge of #65/#85
If there is a need for highlighting the last selection (the last bullet point in the initial comment) we should create a separate issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant