Fix deadlock at startup #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks @igorpisarev I will have a look soon and will merge quickly so we can have a timely patch release with this. I will also add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239
The cause for the deadlock was that the list of sources in
ViewerStatewas modified under the lock, and since it was anObservableList, it immediately notified the listeners about the change while still holding the lock.I've changed it to a regular list and
ViewerStateto implementObservableinstead. It will fire the invalidated event after releasing the lock which eliminates the risk of running into a deadlock.For consistency it will also fire when the viewer transform or the timepoint changes. I also slightly changed types and visibility of the class members in
ViewerStateto make it more straightforward.